Keep as much span info as possible #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TeXitoi Pretty much ready, waiting on review |
|
ping @TeXitoi , sorry for being annoying but I need your opinion to move on |
TeXitoi
requested changes
Sep 9, 2019
|
for #156 a separate commit would be great. |
|
Well, that's final line. I'll go work on AST implementation, should be done in a week or so (I'm kind of overloaded by work/life stuff right now, sorry) |
|
ping @TeXitoi |
|
cc @TeXitoi |
TeXitoi
approved these changes
Sep 16, 2019
|
There is an error message change that fail the nightly build :-( |
|
@TeXitoi They look identical. I'll investigate in few hours |
|
There is an extra message after the ^^^^^^^^ |
CreepySkeleton
changed the title
|
Fucking nightly! Will fix |
Most of `quote!` invocations are replaced with `quote_spanned!` ones. Now everywhere - sometimes it's pointless, sometimes we don't have any meaningless location to toke a span from, sometimes I just can't workaround the current implementation - too much changes.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
Work-in-progress, just so you could state your opinion on this changes
Em, fix to #156 is also here, I can extract it to a separate PR if you want