Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #245 #246

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Fix #245 #246

merged 1 commit into from
Sep 1, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

Closes #245

TeXitoi
TeXitoi requested changes Aug 31, 2019
View reviewed changes
Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be great

@CreepySkeleton
Copy link
Collaborator Author

This is just a fast patch. I'm working on a big refactoring that introduces explicit AST and separates input processing into phases: parse, validate, generate. Current implementation is almost unworkable when it comes to parent - children relationships

TeXitoi
TeXitoi reviewed Sep 1, 2019
View reviewed changes
tests/skip.rs Show resolved Hide resolved
@CreepySkeleton
Fix #245
a574b5c 
Signed-off-by: CreepySkeleton <[email protected]>
@TeXitoi TeXitoi merged commit 14937e8 into TeXitoi:master Sep 1, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Sep 1, 2019

Thanks

@CreepySkeleton CreepySkeleton deleted the bugfix_245 branch September 1, 2019 19:48
@epage epage mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

methods are not allowed for skipped fields when using multi-line doc comments
2 participants
@CreepySkeleton @TeXitoi