Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally add paw support for structopt as a feature #192

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

gameldar
Copy link
Contributor

@gameldar gameldar commented Jun 1, 2019

Create an optional feature that when turned on add in the required paw:ParseArgs trait implementation that allows use of StructOpt as the argument for the fn main.

@gameldar
Copy link
Contributor Author

gameldar commented Jun 1, 2019

Note: this resolves #187

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 1, 2019

A generic impl in src/lib.rs doesn't work?

@gameldar
Copy link
Contributor Author

gameldar commented Jun 1, 2019

A generic impl in src/lib.rs doesn't work?
Oh that was a quick reply! I just wrote that on the bug - but no - you end up with the same error @yoshuawuyts saw that you can't use generic type T on something from a different crate.

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 1, 2019

OK.

Please update the CHANGELOG, and I'll merge. A new version should be published within a week, waiting for a doc improvement.

This adds a feature that can be turned on that will include the
ParseArgs impl when generating the struct and enums
@gameldar gameldar force-pushed the 187-paw-integration branch from fe9925f to d69902a Compare June 1, 2019 08:09
@TeXitoi TeXitoi merged commit 8068f96 into TeXitoi:master Jun 1, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Jun 1, 2019

thanks!

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 1, 2019

v0.2.17 published

TeXitoi pushed a commit that referenced this pull request Jun 26, 2019
This adds a feature that can be turned on that will include the
ParseArgs impl when generating the struct and enums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants