Tesla Cannon #244
Closed
Tesla Cannon #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /obj/item/weapon/gun/energy/tesla/proc/charge(mob/living/user as mob) | ||
| spawn(1) | ||
| if(do_after(user, 40)) |
There was a problem hiding this comment.
Не хватает третьего аргумента - цели. if(do_after(user, 40, target = src)) в данном случае.
| feedback_add_details("gun_fired","[src.type]") | ||
|
|
||
| /obj/item/weapon/gun/energy/tesla/proc/los_check(mob/A,mob/B) | ||
| for(var/atom/turf in getline(A,B)) |
There was a problem hiding this comment.
turf суть часть atom'а, но atom это не только turf. Короче, лучше var/atom/A, потому что твой вариант вводит в заблуждение.
| /obj/item/weapon/gun/energy/tesla/proc/Bolt(mob/origin,mob/target,mob/user = usr,jumps) | ||
| spawn(1) origin.Beam(target,icon_state="lightning[rand(1,12)]",icon='icons/effects/effects.dmi',time=5) | ||
| var/mob/living/carbon/current = target | ||
| current.electrocute_act(15*(jumps+1),"electric bolt",1.0,null,1) |
There was a problem hiding this comment.
Вообще, если посмотреть в прок electrocute_act() то второй аргумент по атому идет, хорошо что он лишь для текста используется и поэтому никаких нет к счастью рантаймов - это я про "electric bolt" что как бы стринг, а не атом. И тоже самое и ниже.
BoredFox
pushed a commit
to BoredFox/TauCetiClassic
that referenced
this pull request
Oct 5, 2018
Новый плейлист в джукбокс
LudwigVonChesterfield
pushed a commit
to LudwigVonChesterfield/TauCetiClassic
that referenced
this pull request
Nov 23, 2018
Новый плейлист в джукбокс
LudwigVonChesterfield
pushed a commit
to LudwigVonChesterfield/TauCetiClassic
that referenced
this pull request
Nov 23, 2018
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zap-zap