Add 'edit_languages' command #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client sent the data to the server, it combined the sentence id and language into a single string. The probable reason for this is the default configuration of the `jeditable` library which uses the id of the surrounding `div` element for the `id` key of the POST data. But it's also possible to format the POST data that is sent and we should take advantage of it. This simplifies the code on the server (and for the new design) and also makes `editSentence` easier to reuse.
Instead of always providing both the text and the language of a sentence, it's now possible to provide only one of them.
This command allows admins to change the language of many sentences from the command line.
|
I didn’t try to run it but the code looks good. 👍 I suggest removing the underscored |
|
Thanks for the review. I will remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command to change the language of many sentences from the command line. This should help in moving all Kurdish sentences to Northern Kurdish (see #2570, point 2) and for splitting other macro languages in the future.
Since I wanted to use
SentencesTable::editSentencefor the updating part, I've also refactored that method to make it more reusable. As a side-effect I've also fixed #1678. 😃