Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transcriptions in the new sentence design #2224

Merged
merged 31 commits into from
Apr 3, 2020
Merged

Transcriptions in the new sentence design #2224

merged 31 commits into from
Apr 3, 2020

Commits on Mar 20, 2020

  1. Display transcriptions in new sentence design

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    db8703c View commit details
    Browse the repository at this point in the history

  2. Create transcription form

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    abdab83 View commit details
    Browse the repository at this point in the history

  3. Display transcriptions for non-authenticated users

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    504660c View commit details
    Browse the repository at this point in the history

  4. Make transcriptions editable only by trusted members

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    82ae272 View commit details
    Browse the repository at this point in the history

  5. Implement logic for showing/hiding transcriptions needing review

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    f435054 View commit details
    Browse the repository at this point in the history

  6. Implement saving and reseting transcription

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    f986f09 View commit details
    Browse the repository at this point in the history

  7. Fix logic of showing/hiding transcriptions in translations

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    7664ba7 View commit details
    Browse the repository at this point in the history

  8. Display transcription below sentence in search results 

    Temporary solution for #1087.
    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    f837f94 View commit details
    Browse the repository at this point in the history

  9. Implement proper permissions for editing transcriptions

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8b02dcb View commit details
    Browse the repository at this point in the history

  10. Implement some error handling

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    801f0dd View commit details
    Browse the repository at this point in the history

  11. Reset value of transcription on cancel

    @trang
    trang committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    fcaf212 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Fix error with 'undefined' sentence in angular code

    @trang
    trang committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    ab33ff0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Add missing transcriptions containment in translations

    @trang
    trang committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    0c5ab1f View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Make transcriptions editable from the sentence form

    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    523911b View commit details
    Browse the repository at this point in the history

  2. Rework logic for showing furigana

    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    540505c View commit details
    Browse the repository at this point in the history

  3. Readjust alignement of transcriptions

    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    f37e696 View commit details
    Browse the repository at this point in the history

  4. Make tooltip appear when hovering over warning icon

    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    d5fa830 View commit details
    Browse the repository at this point in the history

  5. Add button to show hidden transcriptions for non-authenticated users 

    When showing the hidden transcriptions, also expand the translations in case some of the hidden translations have hidden transcriptions.
    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    32001ff View commit details
    Browse the repository at this point in the history

  6. Rework sentence editing 

    Showing edit button also when user can edit the transcription and hiding language and sentence fields if user can only edit the transcription.
    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    32cc5eb View commit details
    Browse the repository at this point in the history

  7. Display info tooltip for reviewed furigana

    @trang
    trang committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4dff906 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Fix wrong tooltip upon saving transcription 

    We have to add the Users as containment to retrieve the user to display in the tooltip.
    @trang
    trang committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c0abe37 View commit details
    Browse the repository at this point in the history

  2. Fix behavior when edited sentence and transcription don't match 

    It's supposed to display an error message, not replace the transcription by the auto-generated one.
    @trang
    trang committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    567cb9b View commit details
    Browse the repository at this point in the history

  3. Display transcription info tooltip above the transcription

    @trang
    trang committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    6218d3a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Rework transcriptions error handling

    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0cd7319 View commit details
    Browse the repository at this point in the history

  2. Refactor PintinHelper and TranscriptionsHelper 

    Using the traits to avoid duplicate code.
    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    54a02f6 View commit details
    Browse the repository at this point in the history

  3. Add additional checks in html and editing_format virtual fields

    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    be4a983 View commit details
    Browse the repository at this point in the history

  4. Rename virtual field editing_format to markup

    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a290587 View commit details
    Browse the repository at this point in the history

  5. Reword tooltip of button to show unreviewed transcriptions

    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d8175a1 View commit details
    Browse the repository at this point in the history

  6. Make $ngIf string more readeable

    @trang
    trang committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    72dfb8c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Rework once more transcriptions error handling

    @trang
    trang committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    3e0e016 View commit details
    Browse the repository at this point in the history

  2. Fix "Cancel" not resetting transcription input value 

    The issue happens if there are errors in the transcription and the users cancels. Cancel relies on `oldSentence` but by using initSentence() we override the `oldSentence`.
    @trang
    trang committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    a8f59ab View commit details
    Browse the repository at this point in the history