Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated uig lang flag #1849

Closed
wants to merge 3 commits into from
Closed

Updated uig lang flag #1849

wants to merge 3 commits into from

Conversation

BaksiLi
Copy link

@BaksiLi BaksiLi commented Mar 31, 2019

This is a new submission after a few discussion here, #1789

@BaksiLi
Copy link
Author

BaksiLi commented Apr 1, 2019

@RyckRichards mate,
What should I do to pass the check? It seems that I have changed only the .svg file.

@jiru
Copy link
Member

jiru commented Apr 2, 2019

@BaksiLi The check fails because the SVG file is too big.

I recently introduced file size checks after I realized that many of the (old) PNG files were very poorly compressed (see 4b8a2c8 and 4b8a2c8). After compressing the PNG files, I set the limit to 2KB because all the PNG files were under 2KB.

After we switched to SVG, we raised the limit to 3KB because it takes a little bit more space to include a PNG image inside SVG. However the 3KB limit is pretty arbitrary since we don’t have much experience with pure SVG files yet.

Your file is 32KB, which may be reasonable giving it’s not compressed. However, would you mind checking if there is anything you can do to reduce the size, like reducing the details of the curves?

Note that the failing check doesn’t prevent your pull request from being merged. We can merge it and adjust the size limit later. 😄

@BaksiLi
Copy link
Author

BaksiLi commented Apr 16, 2019

@jiru I have made another svg with only 2KB and committed. Can you please check it again? Cheers

@trang
Copy link
Member

trang commented Apr 16, 2019

@BaksiLi Your PR is technically okay. The main blocker is that we have to decide whether or not we should change the flag to what you are suggesting. And for that, I think we'll first need to hear from the Uighur speakers. Until then, your PR is most likely going to remain on standby.

@BaksiLi
Copy link
Author

BaksiLi commented Apr 17, 2019

@trang No worries. We should wait until most of us are respected. Best wishes.

@trang
Copy link
Member

trang commented May 26, 2020

@BaksiLi Our decision as of now is to keep the flag as it is. See #1789 (comment). Thank you nonetheless for your suggestion.

@trang trang closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants