Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages that are responsive when logged out are not responsive when logged in #2839

Closed
Yorwba opened this issue Aug 31, 2021 · 4 comments · Fixed by #2855
Closed

Pages that are responsive when logged out are not responsive when logged in #2839

Yorwba opened this issue Aug 31, 2021 · 4 comments · Fixed by #2855
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Milestone

Comments

@Yorwba
Copy link
Contributor

Yorwba commented Aug 31, 2021

Context
Someone joined the XMPP chat to ask whether we have a mobile website/complain about the lack of mobile-friendly design ("if I have to zoom it's not a mobile website" – good rule of thumb, I think.) I asked about their thoughts regarding our search results page, sending the screenshot below:
Logged out
They said that this wasn't what they were seeing, and after some troubleshooting, we realized that this was because I wasn't logged in on my phone.
After logging in, the same page looks like this:
Logged in
I'm not quite sure, but I think this is because the menu at the top is different for logged-in users and doesn't have a responsive version yet. Since this menu appears on every page, logged-in users effectively see no benefit from the responsive design work that has already been completed.

Idea
Cram the menu for logged-in users into the space where the language selector icon would be.

@Yorwba Yorwba added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Aug 31, 2021
@Yorwba
Copy link
Contributor Author

Yorwba commented Aug 31, 2021

This would be part of of the Responsive UI project, but it turns out that I can't add issues to the project board.

@Yorwba
Copy link
Contributor Author

Yorwba commented Sep 22, 2021

I've had a closer look at this today and found out that my guess about the menu was wrong: it does adapt reasonably well when I force the viewport to 360×640 using the responsive design tools in Firefox:
Logged in with 360×640 viewport
So now I'm wondering why the responsive design on the search page is only enabled for guest users. I didn't find an explanation in a comment or commit message or GitHub discussion, although #2473 does mention in the description that it only applies to non-authenticated users. @trang do you remember why?

@trang
Copy link
Member

trang commented Sep 26, 2021

@Yorwba It's because we would also need to ensure that the various contributors features look fine (translating, editing, adding transcriptions, review, adding to list, and maybe other things). Maybe there would not be much to adjust, but that was additional effort that I didn't want to deal with at the time :)

@Yorwba
Copy link
Contributor Author

Yorwba commented Sep 27, 2021

Thank you for the explanation.
I did some testing locally with isResponsive forced to true.

The old design definitely doesn't look fine:
Old design
The sentence blocks expand the width of the page, requiring zooming out to see everything:
Old design zoomed out

On the other hand, the new design looks OK:
New design
The menu does appear a bit weird if it can't fit all icons into a single row:
New design with menu expanded
I think it would be better to have the review buttons in a second row rather than stacking into a tall column.

While testing, I ran into some other outstanding bugs (#1614, #2355) and usability issues (when expanding the menu that includes the copy button, it's very enticing to try tapping onto the newly created whitespace to close it, but one needs to tap the sentence text instead) but the former are independent of the screen size and the latter also applies to unauthenticated users, so they shouldn't be an obstacle to making the responsive design available to authenticated users.

Since making the old design mobile-friendly is probably out of the question, how about serving the responsive search results page only if the new design is being used? (Possibly after redesigning the sentence menu so the icons wrap better.)

@trang trang modified the milestones: 2021-10-17, 2021-10-23 Oct 11, 2021
trang added a commit that referenced this issue Oct 23, 2021
Enable responsive search results if the new design is used (fixes #2839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants