Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the new design, when the menu is expanded, the username is no longer visible #2326

Closed
trang opened this issue May 15, 2020 · 2 comments
Closed

In the new design, when the menu is expanded, the username is no longer visible #2326

trang opened this issue May 15, 2020 · 2 comments
Assignees
@trang
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Milestone
2021-10-23

Comments

@trang
Copy link
Member

trang commented May 15, 2020

Reported by AlanF_US and CK on the Wall:

the user name disappears in "display more" mode, and I don't want to have to keep switching modes.

While we see the the owner's name in the "show less" version, when browsing while showing all the things we need using the "show more" version, we don't see the owners' names, which means we still need to constantly toggle between the two.
@trang trang added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label May 17, 2020
@trang trang self-assigned this May 26, 2020
trang added a commit that referenced this issue May 27, 2020
@trang
Display sentence menu above ID and owner when expanded
f63412b 
Refs #2326.
trang added a commit that referenced this issue May 28, 2020
@trang
Fix sentence header layout for guests
a4a3d44 
The layout needs to be always "row" for guests since the menu only has one item and doesn't expand.

Refs #2326.
@trang trang mentioned this issue May 28, 2020
Closed
@Yorwba
Copy link
Contributor

Yorwba commented Nov 2, 2021

This was fixed in #2855.

@trang trang added this to the 2021-10-23 milestone Nov 4, 2021
@trang
Copy link
Member Author

trang commented Nov 4, 2021

Yes, thanks for the reminder :)

@trang trang closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trang trang

Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Milestone
2021-10-23
Development

No branches or pull requests
2 participants
@trang @Yorwba