CMake: add subproject detection and fix source location. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subproject detection avoids adding things into the build that are not necessary (i.e., standardese, unit tests) and/or may cause conflicts (i.e., `tests` target name) when building as a submodule in a parent project. Also change CMAKE_SOURCE_LOCATION --> CMAKE_CURRENT_SOURCE_LOCATION which is more correct and is needed when the source location is not the top level folder in the project.
Without this then a parent project has to specifically turn off function_ref testing by setting the appropriate flag. This makes testing opt-in when function_ref is a subproject, and can still be turned on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subproject detection avoids adding things into the build that
are not necessary (i.e., standardese, unit tests) and/or may
cause conflicts (i.e.,
teststarget name) when building as asubmodule in a parent project.
Also change
CMAKE_SOURCE_LOCATION-->CMAKE_CURRENT_SOURCE_LOCATIONwhich is more correct and is needed when the source location is
not the top level folder in the project.