Give an error for addresses lacking a hostname #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gperciva
force-pushed
the
no-hostname-sock
branch
from
5c5355c to
104d984
Compare
|
This is an alternate solution to #407. (The commit message was tweaked accordingly.) |
|
Examples of message: |
|
Ok, this adds a more helpful error message, but doesn't solve the problem that Can you write a |
|
Oh! Oops, ok, I get it now. Will do. |
gperciva
force-pushed
the
no-hostname-sock
branch
2 times, most recently
from
0f59685 to
a36347f
Compare
|
Updated. I also added a check for |
gperciva
force-pushed
the
no-hostname-sock
branch
from
a36347f to
a98d619
Compare
gperciva
force-pushed
the
no-hostname-sock
branch
from
a98d619 to
dd3ef01
Compare
A source or destination address of the form ":1234" is parsed as a hostname of "" which is guaranteed to never work. While we don't want to give special error messages for all possible invalid addresses, this particular case can easily be produced from a broken shell script (with a hostname variable accidentally not set), so it's worth having a special error message. Suggested by: Ross Richardson
We want to check that the addresses are syntactically valid before spiped daemonizes. It's not strictly necessary for spipe, but we might as well check it so that we can produce a usage() if necessary. Suggested by: Ross Richardson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A source or destination address of the form ":1234" is parsed as a hostname of "" which is guaranteed to never work. While we don't want to give special error messages for all possible invalid addresses, this particular case can easily be produced from a broken shell script (with a hostname variable accidentally not set), so it's worth having a special error message.
Suggested by: Ross Richardson