-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standalone-enc: use processes instead of threads for socketpair_one #399
Conversation
I don't see any explanation of why you want this change? |
Two reasons:
I can add this to the commit message for 7ab5011. |
Makes sense. Yes, please add some text to the relevant commit message. |
43e3314
to
31c71fa
Compare
31c71fa
to
abec9b2
Compare
This commit has two benefits: 1. It allows us to add a socketpair_two test (which has separate processes for encryption, decryption, input, and output) with less new code. (We can't have encryption and decryption in the same process, because they rely on events_spin(), which isn't thread-safe.) 2. This brings the test closer to the way we'd normally use spiped (i.e. one process from spiped, and at least one other process piping data to it).
abec9b2
to
cc1bedb
Compare
Actually, wait, I want to revisit the number of open file descriptors in the forked processes. I'm not convinced it's wrong, but I'm also not convinced it's right. |
Never mind, this is the normal behaviour of |
No description provided.