Increase maximum value of the p cmdline parameter #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upper limit of the value of the `-p` cmdline parameter is 32, which is relatively low. Currently, hashing with logN=20, r=8 and p=32 takes around 90s on my slow CPU (Intel i3-7020U). This is in contrast to the `--logN` parameter, which can be set up to 40, which corresponds to 1TB of RAM. Additionally, the program will automatically pick high values of `p` when given high values of the `-t` (maxtime) parameter. So allow specifying higher values of the `p` parameter in cmdline. Signed-off-by: Mateusz Jończyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upper limit of the value of the
-pcmdline parameter is 32, which is relatively low. Currently, hashing with logN=20, r=8 and p=32 takes around 90s on my slow CPU (Intel i3-7020U).This is in contrast to the
--logNparameter, which can be set up to 40, which corresponds to 1TB of RAM. Additionally, the program will automatically pick high values ofpwhen given high values of the-t(maxtime) parameter.So allow specifying higher values of the
pparameter in cmdline.