Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memlimit.c: remove leading underscores; handle non-POSIX in build system #349

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

gperciva
Copy link
Member

No description provided.

@gperciva
Copy link
Member Author

Same rational as the apisupport NONPOSIX SETGROUPS check in Tarsnap/libcperciva#445.

I considered adding the whole apisupport infrastructure, but in the end I decided not to. At the moment, the only relevant apisupport check would be "should we remove _POSIX_C__SOURCE and _XOPEN_SOURCE from memlimit.c`?", and previously we've been unconditionally doing so. I don't see the benefit in adding a bunch of additional build complexity just to avoid undefining those values if the compiler isn't being nitpicky.

If we add apisupport for some other reason, then we could reconsider this (although my first instinct would still be to say that there's no harm in unconditionally undefining these). Of course, if there's any platform which requires those terms (which would be a "wat." situation), then I'd be happy to add whatever amount of build system complexity that was required.

@cperciva cperciva merged commit 15df4c2 into master Sep 30, 2022
@gperciva gperciva deleted the memlimit-without-leading-underscores branch October 1, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants