clang static analyzer fixes

http/http.c

@@ -464,6 +464,12 @@ gotheaders(struct http_cookie * H, uint8_t * buf, size_t buflen)
 		    H->res_headlen - bufpos);
 	}
 
+	/*
+	 * We only call gotheaders() if we've found "\r\n\r\n", so we must have
+	 * at least two EOLs.
+	 */
+	assert(H->res.nheaders >= 2);
+
 	/* # headers = # lines - 1 (status-line) - 1 (blank line). */
 	H->res.nheaders -= 2;
 

tests/heap/main.c

@@ -45,7 +45,7 @@ main(int argc, char * argv[])
 		if (strlen(s) != (size_t)l) {
 			warnp("Line of length %zu has embedded NUL: %s",
 			    (size_t)l, s);
-			goto err0;
+			goto err1;
 		}
 
 		/* Remove trailing '\n'. */
@@ -55,13 +55,13 @@ main(int argc, char * argv[])
 		/* Duplicate string. */
 		if ((dups = strdup(s)) == NULL) {
 			warnp("strdup");
-			goto err0;
+			goto err2;
 		}
 
 		/* Insert string. */
 		if (ptrheap_add(H, dups)) {
 			warn0("ptrheap_add");
-			goto err0;
+			goto err2;
 		}
 	}
 
@@ -81,6 +81,10 @@ main(int argc, char * argv[])
 	/* Success! */
 	return (0);
 
+err2:
+	free(s);
+err1:
+	ptrheap_free(H);
 err0:
 	/* Failure! */
 	return (1);

util/daemonize.c

@@ -80,7 +80,7 @@ daemonize(const char * spid)
 		 * releasing them for the benefit of leak checkers.
 		 */
 		if (ipc_sync_done(IS))
-			goto err1;
+			goto err0;
 
 		/* We have been poked by the child.  Exit. */
 		_exit(0);