metabuild and valgrind improvements #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we combined strings with:
d="$a $b $c"
If $b was "", that would leave two spaces, which we trimmed with
tr -s ' '
However, that was an inelegant solution, and more importantly, was not
compatible with code such as:
-D_TWO_SPACES="\"2 spaces\""
when defined in Makefile.BSD.
Ideally, there would always be 0 errors. However, due to porting issues, some platforms report a non-zero number of errors even for trivial programs.
gperciva
commented
Nov 17, 2024
| # Check the error summary. | ||
| # Check the error summary. Get the number of expected errors from the | ||
| # ${valgrind_fds_log} file. (Ideally this would be 0, but due to | ||
| # porting issues, some versions of valgrind on some platforms always |
There was a problem hiding this comment.
At the moment, FreeBSD is one of those systems with "valgrind porting issues".
|
Commit 2d2a2d5 does not result in any change of the generated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.