Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: fix whitespace #522

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Style: fix whitespace #522

merged 1 commit into from
Aug 1, 2024

Conversation

gperciva
Copy link
Member

No description provided.

@gperciva
Copy link
Member Author

This replaces #521.

I think it's been 6-12 months since I last tried to get 3rd-party PRs to allow us to "approve" the github action run, so it's time to try again.

@cperciva
Copy link
Member

Needs a "reported by" tag in the commit message. (Ok @TimWolla only reported one of the three, but it's a matter of principle.)

@gperciva
Copy link
Member Author

Done.

@cperciva
Copy link
Member

cperciva commented Aug 1, 2024

@TimWolla Should this be Reported by: Tim Wolla or Reported by: Tim Düsterhus?

Checked with:
    git grep "^     " -- $**.h" "**.c" ":(exclude)external"

Reported by:	Tim Düsterhus
@gperciva
Copy link
Member Author

gperciva commented Aug 1, 2024

We already have Tim D in the repo as the author of 28dfe29, so it makes sense to use that name for the "Reported by".

Commit message amended.

@TimWolla
Copy link
Contributor

TimWolla commented Aug 1, 2024

Should this be Reported by: Tim Wolla or Reported by: Tim Düsterhus?

As Graham correctly determined, “Tim Düsterhus”.

@TimWolla
Copy link
Contributor

TimWolla commented Aug 1, 2024

I think it's been 6-12 months since I last tried to get 3rd-party PRs to allow us to "approve" the github action run, so it's time to try again.

You would need the pull_request workflow trigger in the workflow definition for it to run on pull requests from forks.

@cperciva cperciva merged commit 661752a into master Aug 1, 2024
2 checks passed
@gperciva gperciva deleted the whitespace branch August 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants