Misc nitpicks #519
Merged
Misc nitpicks #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apisupport-{LIBSSL-HOST_NAME,NONPOSIX-SETGROUPS}.c: <stddef.h> for NULL
elasticarray_perftest.c: <sys/time.h> for struct timeval
mpool.h: <stdint.h> for uint8_t
setuidgid.c: <sys/types.h> for gid_t, uid_t
Reported by: iwyu
We cannot rely on "%d" to print the pid correctly; POSIX specifies that:
pid_t... shall be signed integer types.
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
That page also says:
The implementation shall support one or more programming
environments in which the widths of ... pid_t, ... are no greater
than the width of type long.
but if we were to rely on that, we'd need to check that we were in the
relevant programming environment. Easier just to use "%jd".
Also, ensure that we always print an error message before quitting. The exception is test_assert_failure() in tests/parsenum/main.c, which has a series of tests which (deliberately) end with an abort(), so any subsequent lines of code aren't going to be called.
This should have been part of:
2024-01-13 tests: add fork_func
19efda2
Reported by: cppcheck 2.12.1
This should have been done shortly after:
2024-01-01 Import millisleep.h
bfffdd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.