Add & use ipc_sync.h and ipc_sync.c #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #514. The API is slightly different: it now includes |
gperciva
commented
Apr 23, 2024
|
|
||
| /* close(), but looping upon EINTR. */ | ||
| static inline int | ||
| ipc_sync_close(int fd) |
There was a problem hiding this comment.
Two notable things about this function:
- we will replace it once we have
noeintr_close(). - this function retains the previous behaviour of
daemonize.c, namely that ifclose()hasEINTR, this function callsclose()again. This behaviour is required for HP-UX, but is explicitly wrong for the glibc implementation ofclose(): https://www.man7.org/linux/man-pages/man2/close.2.html
I propose that we keep the same behaviour as before (which is broken on linux), but I thought that I should bring it to your attention.
gperciva
commented
Apr 23, 2024
|
|
||
| /** | ||
| * ipc_sync_wait_prep(IS): | ||
| * Perform any operation(s) that would speed up an upcoming call to |
There was a problem hiding this comment.
This is somewhat vaguely-worded because a different implementation of synchronization might have no "pre-wait" operations. For example, if we used a sem_t on some platforms (since it's not portable everywhere), the _prep() functions would be a no-op.
gperciva
force-pushed
the
ipc-sync-c
branch
2 times, most recently
from
2038282 to
900f8b5
Compare
cperciva
reviewed
Jul 16, 2024
util/daemonize.c
Outdated
| * explicitly closing it for the benefit of leak checkers. | ||
| * Free resources associated with ${IS}. These would be | ||
| * released by the following _exit(), but we're explicitly | ||
| * closing it for the benefit of leak checkers. |
cperciva
reviewed
Jul 16, 2024
util/ipc_sync.h
Outdated
| * 4) both processes: ipc_sync_done() | ||
| * | ||
| * If there's a need to make _wait() or _signal() as fast as possible | ||
| * (i.e. for a benchmark or a performance bottleneck), call the |
|
Ok aside from very minor comment nits. Please fix and then I'll merge. |
gperciva
force-pushed
the
ipc-sync-c
branch
3 times, most recently
from
03129db to
0a85a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.