scripts: misc fixes #488
Merged
scripts: misc fixes #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gperciva
force-pushed
the
scripts-nitpicks
branch
2 times, most recently
from
04110fd to
692aaaf
Compare
This was referenced Jun 27, 2023
Merged
- POSIX/posix-cflags.sh: replace ${NEED_STD_C99} with ${CFLAGS_C99} to
better represent what this variable means. In particular, since it's
going to be used to construct a command line, it should not be quoted.
(At the moment, the only possible values of that variable are "" or
"-std=c99", so it wouldn't matter if we double-quoted it. However,
in theory there might be some compiler which required additional
arguments in order to set it to c99 mode.)
- tests/shared_test_functions.sh: add ${s_count_str} as a "global"
variable. Add a list of "public API" functions.
- tests/shared_valgrind_functions.sh: use ${s_count_str}. Also, import
valgrind_incomplete() to support wait_while with servers.
- tests/18-warnp.sh: don't use $(...), because we don't want to run the
output of check_output. All we want is the exit code, so (...) is the
correct construct.
- apisupport/, cpusupport/, release-tools/: add newlines to separate
code paragraphs.
gperciva
force-pushed
the
scripts-nitpicks
branch
from
692aaaf to
ce82b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.