Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apisupport #145

Closed
wants to merge 5 commits into from
Closed

Apisupport #145

wants to merge 5 commits into from

Conversation

gperciva
Copy link
Member

No description provided.

@gperciva
Copy link
Member Author

In order to address the API-specific #83 (teach entropy.c about non-/dev/urandom APIs), we need to have optional compilation.

My first thought was to include this in cpusupport directly, but then I realized that was silly, since all I needed to do was a bunch of search&replace operations. You can see this in operation in #146.

@gperciva
Copy link
Member Author

sigh. Build failure due to mpool. (#146 has more serious problems, but I was shocked to see this one fail)

@gperciva gperciva added the draft not for merging (yet) label Aug 1, 2018
@gperciva
Copy link
Member Author

gperciva commented Aug 1, 2018

This likely needs a change to cpusupport before it's suitable for merging.

Specifically, I did:
- s/cpu/api/g
- s/CPU/API/g
- removed the CPU features from the bottom of the file

The "run-time" detection might be overkill, but I'm not certain that it
will never be useful, so I figured I'd include it.
These are changes that can't be imported directly into other projects
due to merge conflicts.
@gperciva
Copy link
Member Author

gperciva commented Aug 2, 2018

The above-mentioned change has been made, so I think this is good to go if you like this apisupport in general.

@gperciva gperciva removed the draft not for merging (yet) label Aug 2, 2018
@gperciva gperciva closed this Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant