tests/heap: fix error paths

Reported by: clang19 scan-build
Tarsnap · Nov 26, 2024 · 2884f38 · 2884f38
1 parent 07ffcb3
commit 2884f38
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/tests/heap/main.c b/tests/heap/main.c
@@ -45,7 +45,7 @@ main(int argc, char * argv[])
 		if (strlen(s) != (size_t)l) {
 			warnp("Line of length %zu has embedded NUL: %s",
 			    (size_t)l, s);
-			goto err0;
+			goto err1;
 		}
 
 		/* Remove trailing '\n'. */
@@ -55,13 +55,13 @@ main(int argc, char * argv[])
 		/* Duplicate string. */
 		if ((dups = strdup(s)) == NULL) {
 			warnp("strdup");
-			goto err0;
+			goto err2;
 		}
 
 		/* Insert string. */
 		if (ptrheap_add(H, dups)) {
 			warn0("ptrheap_add");
-			goto err0;
+			goto err2;
 		}
 	}
 
@@ -81,6 +81,10 @@ main(int argc, char * argv[])
 	/* Success! */
 	return (0);
 
+err2:
+	free(s);
+err1:
+	ptrheap_free(H);
 err0:
 	/* Failure! */
 	return (1);