Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Dpos contract calls to new sdk package #583

Open
wants to merge 19 commits into
base: feat/sdk
Choose a base branch
from
Open

Added Dpos contract calls to new sdk package #583

wants to merge 19 commits into from

Conversation

Malak67
Copy link
Contributor

@Malak67 Malak67 commented Sep 25, 2023 •
edited
Loading

Closes #570

VargaElod23
VargaElod23 reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@VargaElod23 VargaElod23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start for a react scope but remember, we need this SDK to work not only on a frontend scope but for backend functionalities too like setting up automated stuff on a server that connects to the DPOS contract.

packages/taraxa-sdk/src/context/TaraxaDposClient.ts Outdated Show resolved Hide resolved
@VargaElod23
Copy link
Contributor

For now this is just a wrapper that provides configuration out of the box, but we need to think about what are the most use-cases and implement utilities for those. Can you take a look at some other SDKs a bit later on to see what they're doing in addition?

@Malak67
Copy link
Contributor Author

Malak67 commented Sep 29, 2023

We are building this SDK step by step. So far it does what is described in the tasks. We will continue working on it and improving it. It is not the latest version.

@Malak67 Malak67 requested a review from VargaElod23 October 16, 2023 09:42
VargaElod23
VargaElod23 requested changes Oct 16, 2023
View reviewed changes
packages/taraxa-sdk/examples/node.ts Outdated Show resolved Hide resolved
packages/taraxa-sdk/src/DposClient.ts Show resolved Hide resolved
packages/taraxa-sdk/src/DposClient.ts Outdated Show resolved Hide resolved
packages/taraxa-sdk/src/DposClient.ts Outdated Show resolved Hide resolved
@Malak67 Malak67 requested a review from VargaElod23 October 16, 2023 10:11
rattrap
rattrap requested changes Oct 23, 2023
View reviewed changes
packages/taraxa-sdk/src/DposClient.ts Outdated Show resolved Hide resolved
packages/taraxa-sdk/src/DposClient.ts Outdated Show resolved Hide resolved
@Malak67 Malak67 requested a review from rattrap October 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VargaElod23 VargaElod23 VargaElod23 approved these changes

@rattrap rattrap Awaiting requested review from rattrap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Malak67 @VargaElod23 @rattrap