Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:disable config loading #2818

Closed
wants to merge 3 commits into from
Closed

chore:disable config loading #2818

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe911ba
chore:disable config loading
MatusKysel Jul 31, 2024
2a200dd
chore: put back var
MatusKysel Jul 31, 2024
1d832d0
do not parse extra data in case it is empty
JakubFornadel Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libraries/config/src/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ void dec_json(Json::Value const &json, DBConfig &db_config) {

std::vector<logger::Config> FullNodeConfig::loadLoggingConfigs(const Json::Value &logging) {
// could be empty if config loaded from json e.g. tests
if (!json_file_name.empty()) {
last_json_update_time = std::filesystem::last_write_time(std::filesystem::path(json_file_name));
}
// if (!json_file_name.empty()) {
// last_json_update_time = std::filesystem::last_write_time(std::filesystem::path(json_file_name));
// }
std::vector<logger::Config> res;
if (!logging.isNull()) {
if (auto path = getConfigData(logging, {"log_path"}, true); !path.isNull()) {
Expand Down
2 changes: 1 addition & 1 deletion libraries/core_libs/node/src/node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ void FullNode::init() {
logging.InitLogging(node_addr);
}

conf_.scheduleLoggingConfigUpdate();
// conf_.scheduleLoggingConfigUpdate();

LOG_OBJECTS_CREATE("FULLND");

Expand Down