Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ficus hf variant #2806

Merged
merged 23 commits into from
Jul 19, 2024
Merged

Ficus hf variant #2806

merged 23 commits into from
Jul 19, 2024

Conversation

JakubFornadel
Copy link
Collaborator

@JakubFornadel JakubFornadel commented Jul 11, 2024 •
edited
Loading

Purpose

Changes:

  • Pillar blocks are created each N pbft blocks
  • Pillar block contain state root & bridge epoch from period N-5
  • Pillar votes for pillar block N have period N+1
  • pbft block N+1 is not finalized unless we have also > 50% of pillar votes with period N+1

This change fixes:

  • potentially getting stalled due to missing pillar chain votes that would no longer be generated
  • asserts are not triggered anymore
  • the latest set of validators control pillar chain consensus

This change requires:

evm pr Taraxa-project/taraxa-evm#242

How does the solution address the problem

Changes made

@JakubFornadel JakubFornadel force-pushed the ficus_hf_variant branch 2 times, most recently from 0052c08 to 683a654 Compare July 11, 2024 19:32
@JakubFornadel JakubFornadel changed the base branch from develop to release/v1.9.0-rc July 11, 2024 20:22
@JakubFornadel JakubFornadel marked this pull request as ready for review July 11, 2024 20:44
@JakubFornadel
Copy link
Collaborator Author

/deploy

@taraxadeploy
Copy link
Collaborator

PR NET pr-2806 Successfully deployed!

explorerhttps://explorer-pr-2806.prnet.taraxa.io
RPChttps://rpc-pr-2806.prnet.taraxa.io
Indexerhttps://indexer-pr-2806.prnet.taraxa.io

Boot Nodes

Boot Node 134.30.147.237
Boot Node 234.133.56.77
Boot Node 335.226.209.106

RPC Nodes

RPC Node 134.133.109.121
RPC Node 234.44.39.209
RPC Node 334.27.192.63

kstdl
kstdl approved these changes Jul 15, 2024
View reviewed changes
for_devs/local-net Outdated Show resolved Hide resolved
@JakubFornadel
Copy link
Collaborator Author

/cleanup

@taraxadeploy
Copy link
Collaborator

prnet cleaned-up successfully

@JakubFornadel JakubFornadel changed the base branch from release/v1.9.0-rc to develop July 18, 2024 00:37
@JakubFornadel JakubFornadel linked an issue Jul 18, 2024 that may be closed by this pull request
Broken Pillar block syncing #2798
Closed
@JakubFornadel JakubFornadel merged commit 31515bc into develop Jul 19, 2024
1 check was pending
@JakubFornadel JakubFornadel deleted the ficus_hf_variant branch July 19, 2024 17:33
@taraxadeploy
Copy link
Collaborator

prnet cleaned-up successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstdl kstdl kstdl approved these changes

@mfrankovi mfrankovi mfrankovi approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Pillar block syncing
6 participants
@JakubFornadel @taraxadeploy @MatusKysel @kstdl @mfrankovi @rattrap