New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: transactions gas estimation cache #2780

Closed

mfrankovi wants to merge 1 commit into develop from est_cache

Contributor

mfrankovi commented Jun 12, 2024

Cache transaction gas estimation to avoid multiple estimations for same transaction.


          chore: gas estimation cache

3ad9a61

mfrankovi requested a review from MatusKysel

June 12, 2024 08:29

MatusKysel reviewed

View reviewed changes

libraries/core_libs/consensus/include/transaction/transaction_manager.hpp

                 // Transactions can be in one of three states:
                 // 1. In transactions pool; 2. In non-finalized Dag block 3. Executed
                 mutable std::shared_mutex transactions_mutex_;
+                mutable std::shared_mutex gas_estimations_mutex_;

Collaborator

MatusKysel Jun 12, 2024

no need for this ExpirationCacheMap is threadsafe

MatusKysel approved these changes

View reviewed changes

MatusKysel closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet