Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor improvements + fixes #2436

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

JakubFornadel
Copy link
Collaborator

@JakubFornadel JakubFornadel commented Apr 5, 2023

Purpose

This PR fixes 2 things:

  • we will now catch up with the rest of network and get within 1 step. Node, which is catching up with the network is increasing its steps 40x faster then the other nodes. This means that if network is stalled for lets say 24 hours, new node will catch up with the networks in about 35 minutes. This is defined by kMinLambda and kMaxLambda. Right now kMaxLambda(60s) / kMinLambda(1.5s) = 40x. We can increase this by increasing kMaxLambda
  • we were not saving and proposing own votes before, which was a pretty important bug -> it is fixed now. Lets say if there is network of 4 nodes and 2 of them go offline. The other 2 proceed to step 100. The other 2 go back online but because we never broadcast current round next votes, the other 2 have to catch with the network (this finally works) but if we were broadcasting also our own next votes for current round (in case we are stalled in the same round), we would be able to move to the next round much sooner.

How does the solution address the problem

Changes made

@JakubFornadel JakubFornadel added this pull request to the merge queue Apr 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2023
@JakubFornadel JakubFornadel added this pull request to the merge queue Apr 10, 2023
Merged via the queue into develop with commit 10dae0b Apr 10, 2023
@JakubFornadel JakubFornadel deleted the exponential_backoff branch April 10, 2023 19:30
@taraxadeploy
Copy link
Collaborator

prnet cleaned-up successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants