fix: missing tip block on tips selection #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
approved these changes
Mar 6, 2023
kstdl
approved these changes
Mar 7, 2023
mfrankovi
force-pushed
the
tip_block_missing
branch
2 times, most recently
from
0a70695 to
cdba9d2
Compare
mfrankovi
force-pushed
the
tip_block_missing
branch
from
cdba9d2 to
6a5d35e
Compare
|
prnet cleaned-up successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a valid case when tip block level expired and block is deleted from DAG where a tip would be missing. Replacing the assert with a log and skipping any tip that is missing.