chore: fix incorrect error log in rewards distribution #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrankovi
requested review from
JakubFornadel,
kstdl,
MatusKysel and
justinsnapp
kstdl
approved these changes
Feb 26, 2023
MatusKysel
approved these changes
Feb 26, 2023
|
prnet cleaned-up successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TotalVotesWeight was equal to twoTPlusOne a incorrect error log is logged, for instance on testnet this is often logged: "DistributeRewards - TotalVotesWeight (667) is smaller than two twoTPlusOne (667)
Distribution was actually ok since even when this was logged, bonusVotesWeight had the default value of 0 which is correct value for this case.