fix: peer chain size #2336
Merged
fix: peer chain size #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mfrankovi
requested review from
JakubFornadel,
justinsnapp,
kstdl and
MatusKysel
MatusKysel
approved these changes
Feb 21, 2023
JakubFornadel
approved these changes
Feb 22, 2023
|
prnet cleaned-up successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vote with the proposed pbft block might be gossiped over nodes that might not be fully synced. We can not assume the chain size from the proposed block to be the same as the peer that sent it. Only exception is if the peer that is sending it is the actual voter.
This might have caused pbft syncing issues related to the issue this PR is linked to