Merge pull request #2399 from Taraxa-project/fix-votes-processing

fix processVote return value check

libraries/core_libs/network/src/tarcap/packets_handlers/common/ext_votes_packet_handler.cpp

@@ -30,7 +30,7 @@ bool ExtVotesPacketHandler::processVote(const std::shared_ptr<Vote> &vote, const
     return false;
   }
 
-  // Validate vote's period, roun and step min/max values
+  // Validate vote's period, round and step min/max values
   if (const auto vote_valid = validateVotePeriodRoundStep(vote, peer, validate_max_round_step); !vote_valid.first) {
     LOG(log_wr_) << "Vote period/round/step " << vote->getHash() << " validation failed. Err: " << vote_valid.second;
     return false;

libraries/core_libs/network/src/tarcap/packets_handlers/vote_packet_handler.cpp

@@ -63,7 +63,7 @@ void VotePacketHandler::process(const PacketData &packet_data, const std::shared
     peer->markPbftBlockAsKnown(pbft_block->getBlockHash());
   }
 
-  if (processVote(vote, pbft_block, peer, true)) {
+  if (!processVote(vote, pbft_block, peer, true)) {
     return;
   }
 

libraries/core_libs/network/src/tarcap/packets_handlers/votes_sync_packet_handler.cpp

@@ -113,8 +113,12 @@ void VotesSyncPacketHandler::process(const PacketData &packet_data, const std::s
 
     // Process processStandardVote is called with false in case of next votes bundle -> does not check max boundaries
     // for round and step to actually being able to sync the current round in case network is stalled
-    bool check_max_round_step = votes_bundle_votes_type == PbftVoteTypes::next_vote ? false : true;
-    if (processVote(vote, nullptr, peer, check_max_round_step)) {
+    bool check_max_round_step =  true;
+    if (votes_bundle_votes_type == PbftVoteTypes::cert_vote || votes_bundle_votes_type == PbftVoteTypes::next_vote) {
+      check_max_round_step = false;
+    }
+
+    if (!processVote(vote, nullptr, peer, check_max_round_step)) {
       continue;
     }