Skip to content

Commit

Permalink
Include missing frameworks in ios tag in plugin.xml
Browse files Browse the repository at this point in the history
  • Loading branch information
@codinronan
codinronan committed Apr 26, 2018
1 parent 008ceb4 commit b5bf8cb
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions plugin.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,20 +91,23 @@
<header-file src="src/ios/BraintreePlugin.h" />
<source-file src="src/ios/BraintreePlugin.m" />

<framework src="lib/ios/Braintree3DSecure.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeAmericanExpress.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeApplePay.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeCard.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeCore.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeDataCollector.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeDropIn.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreePaymentFlow.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreePayPal.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeUI.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeUIKit.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeUnionPay.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeVenmo.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/CardIO.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/PayPalUtils.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/PayPalDataCollector.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/PayPalOneTouch.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeVenmo.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeUnionPay.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeUIKit.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeDropIn.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreePayPal.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeDataCollector.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeCore.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeCard.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/BraintreeApplePay.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/Braintree3DSecure.framework" custom="true" embed="true" weak="false" />
<framework src="lib/ios/PayPalUtils.framework" custom="true" embed="true" weak="false" />

</platform>

Expand Down

2 comments on commit b5bf8cb

@adamfellon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems obvious that this should/would fix the issues I ran into w/ the BraintreePaymentFlow reference in BraintreeDropIn

@codinronan
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfellon Yep! There's one other issue, which I'm not sure the most straightforward fix; if you are using PayPal with the plugin, you need to hard code your BUNDLE_ID.payments string in the URL schemes in *-Info.plist. (e.g. if your app is com.myapp.excellent, hardcode com.myapp.excellent.payments into the URL schemes instead of the ${PRODUCT_BUNDLE_IDENTIFIER}.payments scheme)

This is because cordova still uses the REALLY old version of that variable, so the script that Taraque included doesn't work (not this plugin's fault - cordova needs to modernize the template).

So just make sure you do that manually when building.

Please sign in to comment.