remove error return from constructor

Tantalor93 · Jul 12, 2023 · 3adb6c9 · 3adb6c9
1 parent 93b0030
commit 3adb6c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/doq/client.go b/doq/client.go
@@ -34,7 +34,7 @@ type Options struct {
 }
 
 // NewClient creates a new doq.Client used for sending DoQ queries.
-func NewClient(addr string, options Options) (*Client, error) {
+func NewClient(addr string, options Options) *Client {
 	client := Client{}
 
 	client.addr = addr
@@ -51,7 +51,7 @@ func NewClient(addr string, options Options) (*Client, error) {
 	client.writeTimeout = options.WriteTimeout
 	client.connectTimeout = options.ConnectTimeout
 
-	return &client, nil
+	return &client
 }
 
 func (c *Client) dial(ctx context.Context) error {

diff --git a/doq/client_test.go b/doq/client_test.go
@@ -85,8 +85,7 @@ func Test(t *testing.T) {
 	server.start()
 	defer server.stop()
 
-	client, err := NewClient(server.addr, Options{TLSConfig: generateTLSConfig()})
-	require.NoError(t, err)
+	client := NewClient(server.addr, Options{TLSConfig: generateTLSConfig()})
 
 	msg := dns.Msg{}
 	msg.SetQuestion("example.org.", dns.TypeA)
@@ -103,8 +102,7 @@ func TestWriteTimeout(t *testing.T) {
 	server.start()
 	defer server.stop()
 
-	client, err := NewClient(server.addr, Options{TLSConfig: generateTLSConfig(), WriteTimeout: 1 * time.Nanosecond})
-	require.NoError(t, err)
+	client := NewClient(server.addr, Options{TLSConfig: generateTLSConfig(), WriteTimeout: 1 * time.Nanosecond})
 
 	msg := dns.Msg{}
 	msg.SetQuestion("example.org.", dns.TypeA)
@@ -119,8 +117,7 @@ func TestReadTimeout(t *testing.T) {
 	server.start()
 	defer server.stop()
 
-	client, err := NewClient(server.addr, Options{TLSConfig: generateTLSConfig(), ReadTimeout: 1 * time.Nanosecond})
-	require.NoError(t, err)
+	client := NewClient(server.addr, Options{TLSConfig: generateTLSConfig(), ReadTimeout: 1 * time.Nanosecond})
 
 	msg := dns.Msg{}
 	msg.SetQuestion("example.org.", dns.TypeA)