Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HomeAssistant description field optional #3305

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ehowe
Copy link
Contributor

@ehowe ehowe commented Sep 15, 2024

Some HomeAssistant Todo entities do not support the description field. This includes the default Shopping List entity HA creates and one I use through a custom HA plugin: https://github.com/watkins-matt/home-assistant-google-keep-sync.

This PR adds a configuration to the connector configuration to make this field optional. By default, it is true to maintain backward compatibility with existing connectors, but the user can disable it if their Todo entity does not support it.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024

CLA assistant check
All committers have signed the CLA.

@vabene1111
Copy link
Collaborator

thanks for the PR. I will review the code and get it merged for the next update. @mikhail5555 if you want you can take a look too :)

@mikhail5555
Copy link
Contributor

thanks for the PR. I will review the code and get it merged for the next update. @mikhail5555 if you want you can take a look too :)

Gave it a quick review, looks very un-impactful. Havent touched the form/model/deserialization part in quite a bit so not 100% sure if nothing is missing (or the "initial" field in the form is required for instance).

Would indeed make it also compatible with the 'default' Shopping list entry which trows an error if you send a description field (I believe this was changed in one of the recent version, because prior it just ignored this field)

@vabene1111
Copy link
Collaborator

ok thanks @ehowe for the PR and @mikhail5555 for your feedback, to me everything looks correct as well, so getting this merged for the next update.

@vabene1111 vabene1111 merged commit 26ab7f5 into TandoorRecipes:develop Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants