Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: memoize notify #806

Merged
merged 4 commits into from
Aug 22, 2024
Merged

refactor: memoize notify #806

merged 4 commits into from
Aug 22, 2024

Conversation

piecyk
Copy link
Collaborator

@piecyk piecyk commented Aug 21, 2024

No description provided.

Copy link

nx-cloud bot commented Aug 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cd22559. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 21, 2024

commit: cd22559

@tanstack/angular-virtual

pnpm add https://pkg.pr.new/@tanstack/angular-virtual@806

@tanstack/lit-virtual

pnpm add https://pkg.pr.new/@tanstack/lit-virtual@806

@tanstack/react-virtual

pnpm add https://pkg.pr.new/@tanstack/react-virtual@806

@tanstack/solid-virtual

pnpm add https://pkg.pr.new/@tanstack/solid-virtual@806

@tanstack/svelte-virtual

pnpm add https://pkg.pr.new/@tanstack/svelte-virtual@806

@tanstack/virtual-core

pnpm add https://pkg.pr.new/@tanstack/virtual-core@806

@tanstack/vue-virtual

pnpm add https://pkg.pr.new/@tanstack/vue-virtual@806

Open in Stackblitz

More templates

Copy link

@andreial andreial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@piecyk piecyk merged commit 0ad4e6c into TanStack:main Aug 22, 2024
5 checks passed
@piecyk piecyk deleted the refactor/notify branch August 22, 2024 12:57
@ghost
Copy link

ghost commented Aug 27, 2024

Hi @piecyk, please note that removing measureElement and the generic signature <TItemElement extends Element> from VirtualItem is a breaking change. It just bit me really hard during a pipeline.

@piecyk
Copy link
Collaborator Author

piecyk commented Aug 27, 2024

Hi @piecyk, please note that removing measureElement and the generic signature <TItemElement extends Element> from VirtualItem is a breaking change. It just bit me really hard during a pipeline.

Yes, sorry for that, got mixed up with auto publish script we have.

@juzerzarif
Copy link

Will there be a release on the v3 line to fix the breaking change? Also just ran into this

@piecyk
Copy link
Collaborator Author

piecyk commented Aug 27, 2024

Will there be a release on the v3 line to fix the breaking change? Also just ran into this

Yeah sorry for that, not planing any more on 3x.

In the end adding generic to VirtualItem was a breaking change at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants