feat: Support inverted horizontal scrolling for right-to-left locales #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piecyk
reviewed
Aug 9, 2024
packages/virtual-core/src/index.ts
Outdated
| offset = element[instance.options.horizontal ? 'scrollLeft' : 'scrollTop'] | ||
| const { horizontal, isRtl } = instance.options | ||
| offset = horizontal | ||
| ? element['scrollLeft'] * (isRtl && -1 || 1) |
There was a problem hiding this comment.
Let's keep it simple
Suggested change
| ? element['scrollLeft'] * (isRtl && -1 || 1) | |
| ? element['scrollLeft'] * (isRtl ? -1 : 1) |
Did you test it on all modern browsers?
There was a problem hiding this comment.
We are used to adhering to ESlint's rules regarding ternaries: https://eslint.org/docs/latest/rules/no-nested-ternary
The scenario in the included videos was tested in Safari, Chrome, Firefox, Brave, Opera, and Edge.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c257810. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
Thanks @cachgill 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an option for consumers who need to switch between left-to-right and right-to-left language locales.
With this change, scrolling left-to-right:
https://github.com/user-attachments/assets/93892f15-a5fe-4cdc-8ccf-45c316a966f0
Without this change, scrolling right-to-left:
https://github.com/user-attachments/assets/47aa1cae-de3d-4946-9fd8-29fee19fe560
With this change, scrolling right-to-left:
https://github.com/user-attachments/assets/ab87e0f7-0679-4669-986d-69188d572f7f