Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parent from unnecessary updates when scrolling window. #47

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

shotmk
Copy link
Contributor

@shotmk shotmk commented Aug 13, 2020

Only height and width are used from rect object. No need to update state when this parameters did not change.
This will fix unnecessary updates of parent component when scrolling the page.

@tannerlinsley tannerlinsley merged commit 170c136 into TanStack:master Aug 13, 2020
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants