Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added react-dom as a peer dependency #889

Merged
merged 1 commit into from
May 24, 2018
Merged

Added react-dom as a peer dependency #889

merged 1 commit into from
May 24, 2018

Conversation

shinonomeiro
Copy link
Contributor

Issue: facebook/react#10320

screen shot 2018-03-30 at 17 02 59

I've simply added react-dom as a peer dependency, which for some reason wasn't (but react is). This did solve the problem for my company's project codebase.

I don't know if some other internal compatibility issues might arise due to specific conditions that I cannot possibly test. I do hope for full support of React v16 from the authors though.

@gary-menzel
Copy link
Contributor

It is not a dependency because it is not required by React-Table. React-Table is deliberately "minimal dependency".

From the issue you linked, it appears to be more of an issue with recent version changes between React and React-Dom.

@shinonomeiro
Copy link
Contributor Author

shinonomeiro commented Apr 5, 2018

It is a dependency, albeit a 'peer' one as obviously React-table would be useless without React. I don't understand why React is listed in peerDependencies yet React-dom isn't, although both libraries form a pair and are always updated simultaneously. Most other libraries which encountered this very issue solved it the same way I did in this pull request.

Per the devDependencies listed in package.json (https://github.com/react-tools/react-table/blob/master/package.json#L72), React-dom is locked to v15.4.2 while React itself is allowed to be updated to v16.x.x as listed under peerDependencies, which may result in a version mismatch since npm would have to give React-table its own (outdated) copy of React-dom.

@tannerlinsley tannerlinsley merged commit d430d51 into TanStack:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants