Fix getFacetedMinMaxValues #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dbaaa72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
KevinVandy
reviewed
Aug 3, 2024
|
|
||
| for (let j = 0; j < values.length; j++) { | ||
| const value = values[j]! | ||
| let facetedMinValue = uniqueValues.at(0)! |
There was a problem hiding this comment.
might want to only use es2020 syntax here
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in getFacetedMinMaxValues that I'm surprised no one else has reported or the type checks haven't flagged. Actually, I'm sure I've run into this issue before, but I guess I never got around to reporting it...
The
getUniqueValuesfunction says it returns (and in testing, does return) an array of values. Thus,firstValuebecomes e.g.[123], andfacetedMinMaxValueswill get initialized to[[123], [123]], which sometimes results in the function returning e.g.[123, [123]], depending on the row values. I'm guessing people don't always notice a bug here because an array is being</>compared to a numbe, which I think coerces the array to a string?My first commit makes the minimal change that I think fixes the issue. The second commit reworks the function to be a bit safer imo.