Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not check for browser in package.json #4553

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

DamianOsipiuk
Copy link
Contributor

@KevinVandy Small fix to stop requiring browser field in package.json during deploy as it's breaking older webpack versions.

@KevinVandy
Copy link
Member

Was just looking into this. Thanks

@KevinVandy
Copy link
Member

I believe this should be merged as a feat: RELEASE_ALL so will do that

@KevinVandy
Copy link
Member

@DamianOsipiuk Is this actually related to the webpack "enhanced-resolve" bug? Could be temporary. Will merge this regardless I think

storybookjs/storybook#19927 (comment)

@KevinVandy KevinVandy merged commit 4db33da into TanStack:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants