Add two new built in sort types #3235
Conversation
New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (TanStack#3137).
Add new built-in sort functions 'number' and 'string'
Add new sort types (number, string) to certain columns to achieve sufficient coverage.
|
Someone is attempting to deploy a commit to a Personal Account owned by @tannerlinsley on Vercel. @tannerlinsley first needs to authorize it. |
|
🎉 This PR is included in version 7.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| let aa = a.shift() | ||
| let bb = b.shift() | ||
|
|
||
| let alower = aa.toLowerCase() |
There was a problem hiding this comment.
Shouldn't this use localeCompare and avoid all of the case conversions? This will give the wrong results in a lot of locales.
There was a problem hiding this comment.
Yeah, it probably should. @goldflag would you please open a new PR for this?
| export function string(rowA, rowB, columnId) { | ||
| let [a, b] = getRowValuesByColumnID(rowA, rowB, columnId) | ||
|
|
||
| a = a.split('').filter(Boolean) |
There was a problem hiding this comment.
It seems this throws an exception if the value of a or b are null
There was a problem hiding this comment.
Opened an issue to track this:
#3269
|
|
||
| const replaceNonNumeric = /[^0-9.]/gi | ||
|
|
||
| a = Number(String(a).replace(replaceNonNumeric, '')) |
There was a problem hiding this comment.
@tannerlinsley This creates an absolute value right? Is that really what we want here? This will break the sort if negative and positive values are compared.
Here is a link to a sandbox that showcases the problem: https://codesandbox.io/s/adoring-satoshi-rrw6r?file=/src/App.js
* fix: provide parentRows and data to accessor * docs: add link to LineUp-lite (TanStack#3022) see https://lineup-lite.netlify.app for documentation and details. * docs: use sponsor iframe * Update index.js * docs: ad carbonads * Update index.css * Update index.css * feat: Add two new built in sort types (TanStack#3235) * feat(sortTypes): Add string and number sort types New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (TanStack#3137). * docs(useSortBy): Add two new sort types Add new built-in sort functions 'number' and 'string' * test(useSortBy): Increase coverage for useSortBy Add new sort types (number, string) to certain columns to achieve sufficient coverage. * docs: fix typo (TanStack#3261) * Update index.js * Update index.js * fixed the typo in CodeSandbox link for material UI (TanStack#3555) * v7 links * Update README.md * Update README.md
Add two new build in sort types. Current sort types are unchanged.
Suggested in #3093
numberSorts only numerical values inside column.
stringDoes what is suggersted in Sorting - can't sort titlecase and lowercase #3137.
Sorts case-insensitively until there is a tie and then sorts case-sensitive.