fix: ts-ignore comment prettier issue causing build error (#4611)

* fix ts-ignore comment prettier issue * update publish script to upgrade svelte devDeps
TanStack · Dec 18, 2022 · eb80046 · eb80046
1 parent c4dace9
commit eb80046
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 13 deletions.
diff --git a/examples/svelte/basic/package.json b/examples/svelte/basic/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/examples/svelte/column-groups/package.json b/examples/svelte/column-groups/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/examples/svelte/column-ordering/package.json b/examples/svelte/column-ordering/package.json
@@ -14,7 +14,7 @@
     "@faker-js/faker": "^7.6.0",
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/examples/svelte/column-pinning/package.json b/examples/svelte/column-pinning/package.json
@@ -14,7 +14,7 @@
     "@faker-js/faker": "^7.6.0",
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/examples/svelte/column-visibility/package.json b/examples/svelte/column-visibility/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/examples/svelte/sorting/package.json b/examples/svelte/sorting/package.json
@@ -14,7 +14,7 @@
     "@faker-js/faker": "^7.6.0",
     "@rollup/plugin-replace": "^5.0.1",
     "@sveltejs/vite-plugin-svelte": "^1.0.0-next.42",
-    "@tanstack/svelte-table": "8.7.0",
+    "@tanstack/svelte-table": "8.7.3",
     "@tsconfig/svelte": "^3.0.0",
     "svelte": "^3.44.0",
     "svelte-check": "^2.2.7",

diff --git a/packages/table-core/src/features/ColumnSizing.ts b/packages/table-core/src/features/ColumnSizing.ts
@@ -218,6 +218,8 @@ export const ColumnSizing: TableFeature = {
             ? Math.round(e.touches[0]!.clientX)
             : (e as MouseEvent).clientX
 
+          const newColumnSizing: ColumnSizingState = {}
+
           const updateOffset = (
             eventType: 'move' | 'end',
             clientXPos?: number
@@ -226,8 +228,6 @@ export const ColumnSizing: TableFeature = {
               return
             }
 
-            let newColumnSizing: ColumnSizingState = {}
-
             table.setColumnSizingInfo(old => {
               const deltaOffset = clientXPos - (old?.startOffset ?? 0)
               const deltaPercentage = Math.max(

diff --git a/packages/table-core/src/features/Filters.ts b/packages/table-core/src/features/Filters.ts
@@ -235,8 +235,8 @@ export const Filters: TableFeature = {
           ? column.columnDef.filterFn
           : column.columnDef.filterFn === 'auto'
           ? column.getAutoFilterFn()
-          : // @ts-ignore
-            table.options.filterFns?.[column.columnDef.filterFn as string] ??
+          // @ts-ignore 
+          : table.options.filterFns?.[column.columnDef.filterFn as string] ??
             filterFns[column.columnDef.filterFn as BuiltInFilterFn]
       },
       getCanFilter: () => {
@@ -368,8 +368,8 @@ export const Filters: TableFeature = {
           ? globalFilterFn
           : globalFilterFn === 'auto'
           ? table.getGlobalAutoFilterFn()
-          : // @ts-ignore
-            table.options.filterFns?.[globalFilterFn as string] ??
+          // @ts-ignore
+          : table.options.filterFns?.[globalFilterFn as string] ??
             filterFns[globalFilterFn as BuiltInFilterFn]
       },
 

diff --git a/scripts/publish.ts b/scripts/publish.ts
@@ -500,7 +500,7 @@ async function run() {
                     'package.json'
                   )
                 )
-
+                //upgrade dependencies in react, solid, and vue
                 if (
                   config.dependencies?.[pkg.name] &&
                   config.dependencies[pkg.name] !== depVersion
@@ -510,6 +510,16 @@ async function run() {
                   )
                   config.dependencies[pkg.name] = depVersion
                 }
+                //upgrade devDependencies in svelte (svelte uses devDependencies instead of dependencies)
+                if (
+                  config.devDependencies?.[pkg.name] &&
+                  config.devDependencies[pkg.name] !== depVersion
+                ) {
+                  console.info(
+                    `  Updating ${exampleName}'s devDependencies on ${pkg.name} to version ${depVersion}.`
+                  )
+                  config.devDependencies[pkg.name] = depVersion
+                }
               })
             )
           }