Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy standard schema fix to search validation #2847

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Copy standard schema fix to search validation #2847

merged 1 commit into from
Nov 24, 2024

Conversation

EskiMojo14
Copy link
Contributor

see #2841 for full explanation

@EskiMojo14
Determine validity of standard schema result based on existence of is…
6d89b2e 
…sues, instead of value

Some implementations (namely Valibot) still include the value key for failure results, which is technically still correct in structural typing (since an object type is a *minimum* requirement). What can actually be relied on is that result.issues is undefined if the result is valid, as this is in the spec.

Currently failure results from Valibot are still treated as success.

This commit copies changes over from 73ded2e to the search validation.
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 24, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6d89b2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@EskiMojo14 EskiMojo14 mentioned this pull request Nov 24, 2024
Merged
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 24, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2847

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2847

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2847

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2847

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2847

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2847

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2847

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2847

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2847

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2847

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2847

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2847

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2847

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2847

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2847

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2847

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2847

commit: 6d89b2e

@schiller-manuel schiller-manuel merged commit 76b419e into TanStack:main Nov 24, 2024
4 of 5 checks passed
@EskiMojo14 EskiMojo14 deleted the search-schema-fix branch November 24, 2024 15:58
@EskiMojo14 EskiMojo14 restored the search-schema-fix branch November 24, 2024 15:59
@EskiMojo14 EskiMojo14 deleted the search-schema-fix branch November 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EskiMojo14 @schiller-manuel