Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-query): update devDeps #8427

Merged
merged 3 commits into from
Dec 23, 2024
Merged

chore(react-query): update devDeps #8427

merged 3 commits into from
Dec 23, 2024

Conversation

manudeli
Copy link
Contributor

No description provided.

manudeli
manudeli commented Dec 11, 2024
View reviewed changes
packages/react-query/package.json Outdated
Comment on lines 70 to 71
"@types/react": "npm:types-react@rc",
"@types/react-dom": "npm:types-react-dom@rc",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be stable version now!

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 11, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 23c8736.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 17:18:50 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 11, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8427

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8427

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8427

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8427

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8427

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8427

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8427

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8427

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8427

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8427

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8427

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8427

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8427

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8427

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8427

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8427

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8427

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8427

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8427

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8427

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8427

commit: 23c8736

TkDodo
TkDodo approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I forgot those

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 11, 2024

FYI:

1 issue found in ./:

 ⨯ error Dependency @testing-library/react has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      react-query-devtools      ^16.0.1   ↓ lowest
      react-query-persist-client   ^16.0.1   ↓ lowest
      react-query               ^16.1.0   ↑ highest

1 issue found (1 ⨯, 0 ⚠️, 0 ✓) across 82 packages in 2.30253ms.

@manudeli
Copy link
Contributor Author

@TkDodo In my opinion, I resolved ci error could you check it please?

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 23, 2024

@manudeli there are conflicts now

@manudeli
Copy link
Contributor Author

@manudeli there are conflicts now

I'll resolve it now!

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (1e73d3a) to head (23c8736).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8427   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files         199      199           
  Lines        7512     7512           
  Branches     1715     1712    -3     
=======================================
  Hits         3473     3473           
  Misses       3664     3664           
  Partials      375      375
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query 88.22% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 94.57% <ø> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.54% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.45% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli
Copy link
Contributor Author

@TkDodo I resolved it now!

@TkDodo TkDodo merged commit ee628e1 into TanStack:main Dec 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: react-query package: react-query-devtools package: react-query-next-experimental package: react-query-persist-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo