refactor(angular-query): build with tsup and remove devtools component #8284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e98bab4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8284 +/- ##
=========================================
+ Coverage 0 46.00% +46.00%
=========================================
Files 0 200 +200
Lines 0 7526 +7526
Branches 0 1726 +1726
=========================================
+ Hits 0 3462 +3462
- Misses 0 3687 +3687
- Partials 0 377 +377 |
arnoud-dv
changed the title
arnoud-dv
force-pushed
the
chore/build-angular-tsup
branch
from
9d7016c to
e98bab4
Compare
arnoud-dv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build process of the Angular adapter to use tsup. When not relying on a certain version of the Angular compiler, its mandatory TypeScript version, the Angular runtime or ng-packagr it will be easier to support multiple Angular versions. The Angular packages then only rely on the public API of Angular.
This removes the
<angular-query-devtools>component as components depend on the Angular compiler.In most cases this can simply be replaced by
withDevtools, which will load devtools when Angular runs in developer mode. For more details and configuration, see the devtools documentation.Example of withDevtools