Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): Import noop function from utils #6964

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

saul-atomrigs
Copy link
Contributor

I found several noop function declarations in various files, even though there is already one in query-core/src/utils!

So this PR replaces those noop functions with the one in utils.

** Let me know if adding them in the utils of each directory (svelte-query, react-query, solid-query, angular-query, etc.) is a better approach.

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 11:52am

Copy link

codesandbox-ci bot commented Feb 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26eb0ee:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@saul-atomrigs
Copy link
Contributor Author

Thank you for your feedback!
I have reverted the previous commit and made changes accordingly.

Copy link

nx-cloud bot commented Feb 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 26eb0ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@TkDodo TkDodo merged commit b7b5096 into TanStack:main Feb 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants