-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(types): make queryKey required on ObserverOptions #6879
Conversation
we cannot create an observer without a key, because an observer, per definition, watches a certain query by its key
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fdf7e75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
we can't have an observer without a queryKey
…come first because it doesn't detect length changes
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdf7e75:
|
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6879 +/- ##
==========================================
- Coverage 41.82% 41.78% -0.04%
==========================================
Files 178 178
Lines 7017 7014 -3
Branches 1418 1416 -2
==========================================
- Hits 2935 2931 -4
- Misses 3720 3721 +1
Partials 362 362 |
…ifferent lengths as we use it for options, and the length of options can change
we cannot create an observer without a key, because an observer, per definition, watches a certain query by its key