Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(React Import): Unification of React import method #6553

Merged
merged 7 commits into from
Dec 19, 2023
Merged

refactor(React Import): Unification of React import method #6553

merged 7 commits into from
Dec 19, 2023

Conversation

Lennon57
Copy link
Contributor

Summary

I have removed console.log statements and unified the React import style in the TSX files. Currently, JS and JSX files have not been integrated yet. If requested, I am willing to perform additional tasks. Thank you.

If there is no convention in the import method, you can close the PR.

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 5:10pm

Copy link

codesandbox-ci bot commented Dec 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cbb0826:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link

nx-cloud bot commented Dec 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cbb0826. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 18, 2023

please fix

[warn] packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
[warn] Code style issues found in 1 file. Run Prettier to fix.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95ce0cc) 0.00% compared to head (cbb0826) 93.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #6553       +/-   ##
=========================================
+ Coverage      0   93.97%   +93.97%     
=========================================
  Files         0       21       +21     
  Lines         0      299      +299     
  Branches      0       70       +70     
=========================================
+ Hits          0      281      +281     
- Misses        0       16       +16     
- Partials      0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lennon57
Copy link
Contributor Author

please fix

[warn] packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
[warn] Code style issues found in 1 file. Run Prettier to fix.

@TkDodo Could you please check again? Thank you.

@TkDodo TkDodo merged commit 583c3a8 into TanStack:main Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants