-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont merge arrays in mergeForm
#995
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a4bee41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 91.55% 88.43% -3.13%
==========================================
Files 21 26 +5
Lines 900 1072 +172
Branches 206 262 +56
==========================================
+ Hits 824 948 +124
- Misses 71 115 +44
- Partials 5 9 +4 ☔ View full report in Codecov by Sentry. |
a6f025a
to
ed84226
Compare
not sure why codecov/project is still failing |
- this causes form submissions to be duplicated when having an array field in your form
2f74a75
to
a4bee41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this is the right direction but also I can't think of a better one to prevent duplication so... let's go this way! Thanks for the fix :)
Example of the problem: https://stackblitz.com/edit/tanstack-form-vdj4yh?file=src%2Fapp%2Fshared-code.ts
Just try to submit the form and watch the todos to be duplicated