Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont merge arrays in mergeForm #995

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

rburgst
Copy link
Contributor

@rburgst rburgst commented Oct 28, 2024

  • this causes form submissions to be duplicated when having an array field in your form

Example of the problem: https://stackblitz.com/edit/tanstack-form-vdj4yh?file=src%2Fapp%2Fshared-code.ts

Just try to submit the form and watch the todos to be duplicated

Copy link

nx-cloud bot commented Oct 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a4bee41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 28, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@995

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@995

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@995

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@995

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@995

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@995

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@995

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@995

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@995

commit: a4bee41

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (5473bb8) to head (a4bee41).
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   91.55%   88.43%   -3.13%     
==========================================
  Files          21       26       +5     
  Lines         900     1072     +172     
  Branches      206      262      +56     
==========================================
+ Hits          824      948     +124     
- Misses         71      115      +44     
- Partials        5        9       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rburgst rburgst force-pushed the fix/merge-form branch 2 times, most recently from a6f025a to ed84226 Compare October 29, 2024 06:20
@rburgst
Copy link
Contributor Author

rburgst commented Oct 29, 2024

not sure why codecov/project is still failing

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure this is the right direction but also I can't think of a better one to prevent duplication so... let's go this way! Thanks for the fix :)

@Balastrong Balastrong merged commit 5273091 into TanStack:main Nov 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants