-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update valibot dependency to v1 #972
chore: update valibot dependency to v1 #972
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 242717f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 91.55% 88.40% -3.16%
==========================================
Files 21 26 +5
Lines 900 1069 +169
Branches 206 262 +56
==========================================
+ Hits 824 945 +121
- Misses 71 115 +44
- Partials 5 9 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
Also great idea on the standard schema, that will help a lot ❤️
I've updated the Valibot dependency on TanStack Form to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.
An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.