Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update valibot dependency to v1 #972

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

fabian-hiller
Copy link
Contributor

I've updated the Valibot dependency on TanStack Form to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.


An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.

Copy link

nx-cloud bot commented Oct 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 242717f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@972

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@972

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@972

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@972

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@972

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@972

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@972

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@972

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@972

commit: 242717f

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (5473bb8) to head (242717f).
Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   91.55%   88.40%   -3.16%     
==========================================
  Files          21       26       +5     
  Lines         900     1069     +169     
  Branches      206      262      +56     
==========================================
+ Hits          824      945     +121     
- Misses         71      115      +44     
- Partials        5        9       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Also great idea on the standard schema, that will help a lot ❤️

@Balastrong Balastrong merged commit c8bcc60 into TanStack:main Oct 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants